On Tue, Nov 09, 2021 at 12:50:43PM +1100, Dave Chinner wrote:
> - if (optype & XLOG_START_TRANS) {
> + if (optype) {
Shouldn't this explicitly check for XLOG_START_TRANS or
XLOG_UNMOUNT_TRANS? The cont flags can't really happen here, so it
won't make a functional difference, but it would document the intent
much better.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
