On Fri, Aug 13, 2021 at 01:31:44AM -0500, Alex Sierra wrote: > Device generic type case added for migrate_vma_pages and > migrate_vma_check_page helpers. > Both, generic and private device types have the same > conditions to decide to migrate pages from/to device > memory. This reas a little weird mostly because it doesn't use up the line length nicely: Add the device generic type case to the migrate_vma_pages and migrate_vma_check_page helpers. This new case is handled identically to the existing device private case. > + * We support migrating to private and generic types for device > + * zone memory. Don't spill comments over 80 characters. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>