> -extern void xfs_bmbt_disk_get_all(xfs_bmbt_rec_t *r, xfs_bmbt_irec_t *s); > +extern void xfs_bmbt_disk_get_all(const struct xfs_bmbt_rec *r, > + struct xfs_bmbt_irec *s); Might be worth to drop the extern while you're at it. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>