Re: [PATCH 2/8] xfsprogs: Rename platform.h -> common.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 8/3/21 12:33 AM, Darrick J. Wong wrote:
On Mon, Aug 02, 2021 at 11:50:18PM +0200, Pavel Reichl wrote:
No other platform then linux is supported so rename to something more
common.
---
  copy/xfs_copy.c                  | 2 +-
  libfrog/{platform.h => common.h} | 0
This is confusing, we already have a scrub/common.h.  Renaming files
breaks git blame; why change them?

I wanted to rename the file because it contains functions that were supposed to be multi-platform (at least that's my understanding) but it never became the case. So since we are trying to get rid of the obsolete 'platform_' prefix I thought that more proper name for the file should be chosen. However, I respect the git blame consideration and I'm fine with keeping the name.




[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux