Re: [PATCH 3/8] xfsprogs: remove platform_uuid_compare()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 8/3/21 12:35 AM, Darrick J. Wong wrote:
On Mon, Aug 02, 2021 at 11:50:19PM +0200, Pavel Reichl wrote:
---
  copy/xfs_copy.c      | 2 +-
  db/sb.c              | 2 +-
  include/linux.h      | 5 -----
It's fine to change the platform_uuid_compare usages inside xfsprogs
itself, but linux.h is shipped as part of the development headers, which
means that you can't get rid of the wrapper functions without causing
build problems for other userspace programs.

--D

OK, maybe it would be best to split the effort into more steps:

1) A patchset that stops using platform_* functions and replace them with standard linux calls inside xfsprogs

2) A patchset that adds deprecation warnings into publicly visible platform_*() calls

3) Fix userspace programs now using the deprecated functions

4) Remove completely platform_*() functions from xfsprogs

Would that be a suitable path?

Thanks!




[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux