On 28 Jul 2021 at 12:53, Chandan Babu R wrote: > On 28 Jul 2021 at 04:40, Darrick J. Wong wrote: >> On Mon, Jul 26, 2021 at 05:15:41PM +0530, Chandan Babu R wrote: >>> This commit adds a new error tag to allow user space tests to check if V5 >>> bulkstat ioctl skips reporting inodes with large extent count. >>> >>> Signed-off-by: Chandan Babu R <chandanrlinux@xxxxxxxxx> >> >> Keep in mind that each of these injection knobs costs us 4 bytes per >> mount. No particular objections, but I don't know how urgently we need >> to do that to test a corner case... >> > > How about using the existing error tag XFS_RANDOM_REDUCE_MAX_IEXTENTS instead > of creating a new one? XFS_RANDOM_REDUCE_MAX_IEXTENTS conveys the meaning that > we use a pseudo max data/attr fork extent count. IMHO this fits into the > bulkstat testing use case where we use a pseudo max data fork extent count. Sorry, I actually meant to refer to XFS_ERRTAG_REDUCE_MAX_IEXTENTS instead of XFS_RANDOM_REDUCE_MAX_IEXTENTS. -- chandan
