Re: [PATCH v21 11/13] xfs: Add delattr mount option

[Allison Henderson <allison.henderson@xxxxxxxxxx>]

On 7/8/21 9:14 PM, Darrick J. Wong wrote:
> On Wed, Jul 07, 2021 at 03:21:09PM -0700, Allison Henderson wrote:
> > This patch adds a mount option to enable delayed attributes. Eventually
> > this can be removed when delayed attrs becomes permanent.
> >
> > Signed-off-by: Allison Henderson <allison.henderson@xxxxxxxxxx>
> > ---
> >   fs/xfs/libxfs/xfs_attr.h | 2 +-
> >   fs/xfs/xfs_mount.h       | 1 +
> >   fs/xfs/xfs_super.c       | 6 +++++-
> >   fs/xfs/xfs_xattr.c       | 2 ++
> >   4 files changed, 9 insertions(+), 2 deletions(-)
> >
> > diff --git a/fs/xfs/libxfs/xfs_attr.h b/fs/xfs/libxfs/xfs_attr.h
> > index 859dbef..5141958 100644
> > --- a/fs/xfs/libxfs/xfs_attr.h
> > +++ b/fs/xfs/libxfs/xfs_attr.h
> > @@ -30,7 +30,7 @@ struct xfs_attr_list_context;
> >   
> >   static inline bool xfs_hasdelattr(struct xfs_mount *mp)
> >   {
> > -	return false;
> > +	return mp->m_flags & XFS_MOUNT_DELATTR;
> >   }
> >   
> >   /*
> > diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h
> > index 66a47f5..2945868 100644
> > --- a/fs/xfs/xfs_mount.h
> > +++ b/fs/xfs/xfs_mount.h
> > @@ -257,6 +257,7 @@ typedef struct xfs_mount {
> >   #define XFS_MOUNT_NOATTR2	(1ULL << 25)	/* disable use of attr2 format */
> >   #define XFS_MOUNT_DAX_ALWAYS	(1ULL << 26)
> >   #define XFS_MOUNT_DAX_NEVER	(1ULL << 27)
> > +#define XFS_MOUNT_DELATTR	(1ULL << 28)	/* enable delayed attributes */
> >   
> >   /*
> >    * Max and min values for mount-option defined I/O
> > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> > index c30b077..1a7edae 100644
> > --- a/fs/xfs/xfs_super.c
> > +++ b/fs/xfs/xfs_super.c
> > @@ -94,7 +94,7 @@ enum {
> >   	Opt_filestreams, Opt_quota, Opt_noquota, Opt_usrquota, Opt_grpquota,
> >   	Opt_prjquota, Opt_uquota, Opt_gquota, Opt_pquota,
> >   	Opt_uqnoenforce, Opt_gqnoenforce, Opt_pqnoenforce, Opt_qnoenforce,
> > -	Opt_discard, Opt_nodiscard, Opt_dax, Opt_dax_enum,
> > +	Opt_discard, Opt_nodiscard, Opt_dax, Opt_dax_enum, Opt_delattr
> >   };
> >   
> >   static const struct fs_parameter_spec xfs_fs_parameters[] = {
> > @@ -139,6 +139,7 @@ static const struct fs_parameter_spec xfs_fs_parameters[] = {
> >   	fsparam_flag("nodiscard",	Opt_nodiscard),
> >   	fsparam_flag("dax",		Opt_dax),
> >   	fsparam_enum("dax",		Opt_dax_enum, dax_param_enums),
> > +	fsparam_flag("delattr",		Opt_delattr),
> >   	{}
> >   };
> >   
> > @@ -1277,6 +1278,9 @@ xfs_fs_parse_param(
> >   		xfs_mount_set_dax_mode(parsing_mp, result.uint_32);
> >   		return 0;
> >   #endif
> > +	case Opt_delattr:
> > +		parsing_mp->m_flags |= XFS_MOUNT_DELATTR;
> > +		return 0;
>
> Can we restrict this to CONFIG_XFS_DEBUG=y or at least log the usual
>
> "EXPERIMENTAL logged xattrs feature in use, use at your orkgs!"
>
> message at mount?
Sure, will add that in.  Thx!
Allison

> --D
>
> >   	/* Following mount options will be removed in September 2025 */
> >   	case Opt_ikeep:
> >   		xfs_fs_warn_deprecated(fc, param, XFS_MOUNT_IKEEP, true);
> > diff --git a/fs/xfs/xfs_xattr.c b/fs/xfs/xfs_xattr.c
> > index 66b334f..7335423 100644
> > --- a/fs/xfs/xfs_xattr.c
> > +++ b/fs/xfs/xfs_xattr.c
> > @@ -8,6 +8,8 @@
> >   #include "xfs_shared.h"
> >   #include "xfs_format.h"
> >   #include "xfs_log_format.h"
> > +#include "xfs_trans_resv.h"
> > +#include "xfs_mount.h"
> >   #include "xfs_da_format.h"
> >   #include "xfs_trans_resv.h"
> >   #include "xfs_mount.h"
> > --
> > 2.7.4