Hi all, This set is a subset of a larger series parent pointers. Delayed attributes allow attribute operations (set and remove) to be logged and committed in the same way that other delayed operations do. This allows more complex operations (like parent pointers) to be broken up into multiple smaller transactions. To do this, the existing attr operations must be modified to operate as a delayed operation. This means that they cannot roll, commit, or finish transactions. Instead, they return -EAGAIN to allow the calling function to handle the transaction. In this series, we focus on only the delayed attribute portion. We will introduce parent pointers in a later set. The set as a whole is a bit much to digest at once, so I usually send out the smaller sub series to reduce reviewer burn out. But the entire extended series is visible through the included github links. Updates since v20: Since this series is introducing a new log item, we need to be setting the incompat flag for older kernels that cannot parse these new items. I have added two patches from Darricks dev tree that handle setting and clearing incompat flags, and a new XFS_SB_FEAT_INCOMPAT_LOG_DELATTR flag is added and set in patch 6. This series can be viewed on github here: https://github.com/allisonhenderson/xfs_work/tree/delayed_attrs_v21 As well as the extended delayed attribute and parent pointer series: https://github.com/allisonhenderson/xfs_work/tree/delayed_attrs_v21_extended And the test cases: https://github.com/allisonhenderson/xfs_work/tree/pptr_xfstestsv3 In order to run the test cases, you will need have the corresponding xfsprogs changes as well. Which can be found here: https://github.com/allisonhenderson/xfs_work/tree/delayed_attrs_xfsprogs_v21 https://github.com/allisonhenderson/xfs_work/tree/delayed_attrs_xfsprogs_v21_extended To run the xfs attributes tests run: check -g attr To run as delayed attributes run: export MOUNT_OPTIONS="-o delattr" check -g attr To run parent pointer tests: check -g parent I've also made the corresponding updates to the user space side as well, and ported anything they need to seat correctly. Questions, comment and feedback appreciated! Allison Allison Collins (1): xfs: Add xfs_attr_set_deferred and xfs_attr_remove_deferred Allison Henderson (12): xfs: Return from xfs_attr_set_iter if there are no more rmtblks to process xfs: Add state machine tracepoints xfs: Rename __xfs_attr_rmtval_remove xfs: Handle krealloc errors in xlog_recover_add_to_cont_trans xfs: Set up infrastructure for deferred attribute operations xfs: Implement attr logging and replay RFC xfs: Skip flip flags for delayed attrs xfs: Remove unused xfs_attr_*_args xfs: Add delayed attributes error tag xfs: Add delattr mount option xfs: Merge xfs_delattr_context into xfs_attr_item xfs: Add helper function xfs_attr_leaf_addname fs/xfs/Makefile | 1 + fs/xfs/libxfs/xfs_attr.c | 422 ++++++++++---------- fs/xfs/libxfs/xfs_attr.h | 57 ++- fs/xfs/libxfs/xfs_attr_leaf.c | 3 +- fs/xfs/libxfs/xfs_attr_remote.c | 38 +- fs/xfs/libxfs/xfs_attr_remote.h | 6 +- fs/xfs/libxfs/xfs_defer.c | 1 + fs/xfs/libxfs/xfs_defer.h | 3 + fs/xfs/libxfs/xfs_errortag.h | 4 +- fs/xfs/libxfs/xfs_format.h | 4 +- fs/xfs/libxfs/xfs_log_format.h | 44 ++- fs/xfs/libxfs/xfs_log_recover.h | 2 + fs/xfs/scrub/common.c | 2 + fs/xfs/xfs_acl.c | 2 + fs/xfs/xfs_attr_item.c | 856 ++++++++++++++++++++++++++++++++++++++++ fs/xfs/xfs_attr_item.h | 52 +++ fs/xfs/xfs_attr_list.c | 1 + fs/xfs/xfs_error.c | 3 + fs/xfs/xfs_ioctl.c | 2 + fs/xfs/xfs_ioctl32.c | 2 + fs/xfs/xfs_iops.c | 2 + fs/xfs/xfs_log_recover.c | 12 +- fs/xfs/xfs_mount.h | 1 + fs/xfs/xfs_ondisk.h | 2 + fs/xfs/xfs_super.c | 6 +- fs/xfs/xfs_trace.h | 25 ++ fs/xfs/xfs_xattr.c | 3 + 27 files changed, 1309 insertions(+), 247 deletions(-) create mode 100644 fs/xfs/xfs_attr_item.c create mode 100644 fs/xfs/xfs_attr_item.h -- 2.7.4
