On Mon, Jun 21, 2021 at 02:38:45PM +0800, Eryu Guan wrote: > On Mon, Jun 21, 2021 at 06:25:14AM +0100, Christoph Hellwig wrote: > > On Fri, Jun 18, 2021 at 08:56:30AM -0700, Darrick J. Wong wrote: > > > On Fri, Jun 18, 2021 at 06:32:18PM +0300, Amir Goldstein wrote: > > > > On Fri, Jun 18, 2021 at 4:47 PM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > > > > > > > > > On Thu, Jun 17, 2021 at 10:15:00AM -0700, Darrick J. Wong wrote: > > > > > > I suppose I could make the '-g' switch call 'make group.list', though > > > > > > that's just going to increase the amount of noise for anyone like me who > > > > > > runs fstests with a mostly readonly rootfs. > > > > > > > > > > Just stick to the original version and see if anyone screams loud > > > > > > > > What is the original version? > > > > > > Assuming the developer is smart enough to run 'make all install' before > > > running fstests. > > > > So install is also required now? I have never before installed xfstests > > I think. Sorry, that should have read “...enough to run 'make all' or 'make install' before running...”. > No, install is not required, but running make after updating fstests is > required, at least some tests may introduce new test binary in src and > the binary is missing if you don't run make. So I think make is fine > after updating fstests. Ok, I'll leave this as it was and resubmit the series with the other tweaks suggested by Christoph. --D > Thanks, > Eryu
