On Wed, Jun 02, 2021 at 03:25:24PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > As part of removing the indirect calls and radix tag implementation > details from the incore inode walk loop, create an enum to represent the > goal of the inode iteration. More immediately, this separate removes > the need for the "ICI_NOTAG" define which makes little sense. > > Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx> > --- > fs/xfs/xfs_icache.c | 55 ++++++++++++++++++++++++++++++++++++++++----------- > fs/xfs/xfs_icache.h | 9 -------- > 2 files changed, 43 insertions(+), 21 deletions(-) Nice. I like the XFS_ICWALK_NULL_TAG addition. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx