On Wed, Apr 21, 2021 at 10:41:35PM +0800, Gao Xiang wrote:
> An uninitialized variable issue reported by Coverity, it seems
Minor nit: we often include the coverity id for things it finds.
Links to a semi-private corporate bug tracker aren't necessarily
generally useful, but I guess they did find a legit bug so we could
throw them one crumb.
> the following for-loop can be exited in advance with isblock == 1,
> and bp is still uninitialized.
>
> In case of that, initialize bp as NULL in advance to avoid this.
>
> Fixes: 1f7c7553489c ("repair: don't duplicate names in phase 6")
> Signed-off-by: Gao Xiang <hsiangkao@xxxxxxxxxx>
Either way, it's not worth holding up this patch, so:
Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx>
--D
> ---
> repair/phase6.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/repair/phase6.c b/repair/phase6.c
> index 72287b5c..6bddfefa 100644
> --- a/repair/phase6.c
> +++ b/repair/phase6.c
> @@ -2195,7 +2195,7 @@ longform_dir2_entry_check(
> int ino_offset,
> struct dir_hash_tab *hashtab)
> {
> - struct xfs_buf *bp;
> + struct xfs_buf *bp = NULL;
> xfs_dablk_t da_bno;
> freetab_t *freetab;
> int i;
> --
> 2.27.0
>
