[PATCH] repair: fix an uninitialized variable issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



An uninitialized variable issue reported by Coverity, it seems
the following for-loop can be exited in advance with isblock == 1,
and bp is still uninitialized.

In case of that, initialize bp as NULL in advance to avoid this.

Fixes: 1f7c7553489c ("repair: don't duplicate names in phase 6")
Signed-off-by: Gao Xiang <hsiangkao@xxxxxxxxxx>
---
 repair/phase6.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/repair/phase6.c b/repair/phase6.c
index 72287b5c..6bddfefa 100644
--- a/repair/phase6.c
+++ b/repair/phase6.c
@@ -2195,7 +2195,7 @@ longform_dir2_entry_check(
 	int			ino_offset,
 	struct dir_hash_tab	*hashtab)
 {
-	struct xfs_buf		*bp;
+	struct xfs_buf		*bp = NULL;
 	xfs_dablk_t		da_bno;
 	freetab_t		*freetab;
 	int			i;
-- 
2.27.0




[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux