On Mon, Apr 05, 2021 at 10:59:01AM -0400, Brian Foster wrote:
> Open code xfs_ioend_needs_workqueue() into the only remaining
> caller.
>
> Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx>
I would have left it, but don't really care either way...
Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx>
--D
> ---
> fs/xfs/xfs_aops.c | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
> index c1951975bd6a..63ecc04de64f 100644
> --- a/fs/xfs/xfs_aops.c
> +++ b/fs/xfs/xfs_aops.c
> @@ -206,13 +206,6 @@ xfs_end_io(
> }
> }
>
> -static inline bool xfs_ioend_needs_workqueue(struct iomap_ioend *ioend)
> -{
> - return xfs_ioend_is_append(ioend) ||
> - ioend->io_type == IOMAP_UNWRITTEN ||
> - (ioend->io_flags & IOMAP_F_SHARED);
> -}
> -
> STATIC void
> xfs_end_bio(
> struct bio *bio)
> @@ -472,7 +465,9 @@ xfs_prepare_ioend(
>
> memalloc_nofs_restore(nofs_flag);
>
> - if (xfs_ioend_needs_workqueue(ioend))
> + /* send ioends that might require a transaction to the completion wq */
> + if (xfs_ioend_is_append(ioend) || ioend->io_type == IOMAP_UNWRITTEN ||
> + (ioend->io_flags & IOMAP_F_SHARED))
> ioend->io_bio->bi_end_io = xfs_end_bio;
> return status;
> }
> --
> 2.26.3
>
