On Wed, Apr 07, 2021 at 07:24:13AM -0400, Brian Foster wrote: > On Wed, Apr 07, 2021 at 07:34:40AM +0100, Christoph Hellwig wrote: > > On Mon, Apr 05, 2021 at 10:59:01AM -0400, Brian Foster wrote: > > > Open code xfs_ioend_needs_workqueue() into the only remaining > > > caller. > > > > This description would all fit on a single line. > > > > I've used 68 character wide commit log descriptions for quite some time, > to which this seems to be wrapped accurately. This is the same as the > immediately previous patch for example, with the much longer > description. I don't care much about changing it, but is there a > canonical format defined somewhere? I've always just thought 68-72 was > acceptable. I set email to wrap at 72 and C code to wrap at 79 columns. Though as I've said in the past, I don't enforce /any/ of those rules with any specificity so long as they're not being abused. (e.g. wrapping at column 5 or 500) --D > Brian > > > Looks good: > > > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > > >
