On Tue, Apr 06, 2021 at 04:40:16PM +0100, Christoph Hellwig wrote: > On Tue, Apr 06, 2021 at 09:59:20PM +1000, Dave Chinner wrote: > > From: Dave Chinner <dchinner@xxxxxxxxxx> > > > > The pitfalls of regression testing on a machine without realising > > that selinux was disabled. Only set the attr fork during inode > > allocation if the attr feature bits are already set on the > > superblock. > > This doesn't apply to the current xfs/for-next tree to me, with > rejects in xfs_default_attroffset. Not sure why you'd get rejects in xfs_default_attroffset() given this patch doesn't change that function at all. The whole series applies fine here on 5.12-rc6 + xfs/for-next. Head of the xfs/for-next branch I'm using is commit 25dfa65f8149 ("xfs: fix xfs_trans slab cache name") which matches the head commit in the kernel.org tree... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx