Hi Darrick, On Tue, Mar 09, 2021 at 06:09:47PM -0800, Darrick J. Wong wrote: ... > > > > As Darrick has reviewed, I have one more question. Looks like we can shrink a > > mounted xfs via giving a smaller size to xfs_growfs. > > > > If xfs_growfs or kernel doesn't support 'shrink', I think the whole test will > > be failed. So maybe we need a _require_* function to check if current xfs > > support shrinking feature at first? > > Also, it's time to send the xfs_growfs patches to the list so I can > replicate the tests on my own test vms. There was a preliminary version of xfsprogs sent out before to match this version: https://lore.kernel.org/r/20201028114010.545331-1-hsiangkao@xxxxxxxxxx https://lore.kernel.org/linux-xfs/20201028114010.545331-1-hsiangkao@xxxxxxxxxx/raw This added a EXPERIMENTAL warning but without a new argument for shrinking. Thanks, Gao Xiang