On Thu, Feb 25, 2021 at 10:03:37AM +0100, Christoph Hellwig wrote: > Any reason to not just mark them static inline and move them to > xfs_types.h? Circular header file dependencies. xfs_mount.h needs xfs_types.h and moving these to xfs_types.h means xfs_types.h now depends on xfs_mount.h and a bunch of other header files... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx