On 2/7/21 4:15 PM, Dave Chinner wrote: > On Sun, Feb 07, 2021 at 05:06:36AM +0000, bugzilla-daemon@xxxxxxxxxxxxxxxxxxx wrote: >> https://bugzilla.kernel.org/show_bug.cgi?id=211605 >> >> Bug ID: 211605 >> Summary: Re-mount XFS causes "noattr2 mount option is >> deprecated" warning >> Product: File System >> Version: 2.5 >> Kernel Version: 5.10.13 >> Hardware: All >> OS: Linux >> Tree: Mainline >> Status: NEW >> Severity: low >> Priority: P1 >> Component: XFS >> Assignee: filesystem_xfs@xxxxxxxxxxxxxxxxxxxxxx >> Reporter: cuihao.leo@xxxxxxxxx >> Regression: No >> ... > The kernel is warning about a mount option being specified that > isn't even in the set emitted in /proc/mounts. Nor is it on your > command line. Yet the kernel is warning about it, and that implies > that mount has passed it to the kernel incorrectly. I am confused about how "noattr2" showed up. But we do still emit "attr2" in /proc/mounts, and a remount will complain about /that/, so we do need to stop emitting deprecated options in /proc/mounts. # mount /dev/pmem0p1 /mnt/test # grep pmem /proc/mounts /dev/pmem0p1 /mnt/test xfs rw,seclabel,relatime,attr2,inode64,logbufs=8,logbsize=32k,noquota 0 0 # mount -o remount,ro /mnt/test # dmesg | tail -n 1 [346311.064017] XFS: attr2 mount option is deprecated. Pavel, can you fix this up, since your patch did the deprecations? I guess we missed this on review. Ideally the xfs(5) man page in xfsprogs should be updated as well to reflect the deprecated items. -Eric
