https://bugzilla.kernel.org/show_bug.cgi?id=211605 Bug ID: 211605 Summary: Re-mount XFS causes "noattr2 mount option is deprecated" warning Product: File System Version: 2.5 Kernel Version: 5.10.13 Hardware: All OS: Linux Tree: Mainline Status: NEW Severity: low Priority: P1 Component: XFS Assignee: filesystem_xfs@xxxxxxxxxxxxxxxxxxxxxx Reporter: cuihao.leo@xxxxxxxxx Regression: No Created attachment 295103 --> https://bugzilla.kernel.org/attachment.cgi?id=295103&action=edit proposed fix After recent kernel update, I notice "XFS: noattr2 mount option is deprecated." kernel message every time I shutdown the system. It turns out that remounting a XFS causes the warning. Steps to Reproduce: 1) Mount a XFS and remount it with different options: > $ mount some_xfs.img /mnt/test > $ mount -o remount,ro /mnt/test 2) Check kernel message. Remounting causes a line of warning: > XFS: noattr2 mount option is deprecated. I had checked my fstab and kernel params and didn't found any use of "attr2" option. It doesn't break things, but is a little confusing. Build Information: Arch Linux stock kernel. Linux cvhc-tomato 5.10.13-arch1-1 #1 SMP PREEMPT Wed, 03 Feb 2021 23:44:07 +0000 x86_64 GNU/Linux Additional Information: The warning is introduced in commit c23c393e. I guess remounting triggers it because XFS driver still writes attr2 option to /proc/mounts: > $ grep attr2 /proc/mounts > /dev/nvme0n1p3 / xfs rw,noatime,attr2,inode64,logbufs=8,logbsize=32k,noquota > 0 0 "attr2" is default so it should be omitted in mount options. A potential fix (attached, untested) is to hide it and make "noattr2" explicit in xfs_fs_show_options. -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
