On Mon, Jan 11, 2021 at 05:30:54PM +0000, Christoph Hellwig wrote: > On Mon, Jan 11, 2021 at 08:17:49AM +0800, Gao Xiang wrote: > > Okay, will leave the definitions in the next version. > > Note that the important thing is to not break the kernel to userspace > ABI, the API is a little less important. That being said breaking > programs piecemail for no good reason't isn't nice. I think we > should probably move all the typedefs to the end of the file with > a comment and then at some point remove them as a single breaking > change. Agree with your point. Yet I'm not sure if it's much related to this series (I raised this due to touch some code)... I think it'd be better as an independent xfs-treewide patch to move all userspace visable typedefs to a unique place at once (not just these two typedefs...) But I'm also ok if just move these two types in advance if needed. (I suffer from lack of modification of old typedefs out of copy & paste from time to time. IMHO, I hope such exist typedef usage could be removed as soon as possible... ) Thanks, Gao Xiang >
