On 1/8/21 3:21 PM, Darrick J. Wong wrote:
> On Sat, Jan 09, 2021 at 03:09:17AM +0800, Gao Xiang wrote:
>> Such usage isn't encouraged by the kernel coding style.
>>
>> Signed-off-by: Gao Xiang <hsiangkao@xxxxxxxxxx>
>> ---
>> fs/xfs/libxfs/xfs_fs.h | 4 ++--
>> fs/xfs/xfs_fsops.c | 12 ++++++------
>> fs/xfs/xfs_fsops.h | 4 ++--
>> fs/xfs/xfs_ioctl.c | 4 ++--
>> 4 files changed, 12 insertions(+), 12 deletions(-)
>>
>> diff --git a/fs/xfs/libxfs/xfs_fs.h b/fs/xfs/libxfs/xfs_fs.h
>> index 2a2e3cfd94f0..a17313efc1fe 100644
>> --- a/fs/xfs/libxfs/xfs_fs.h
>> +++ b/fs/xfs/libxfs/xfs_fs.h
>> @@ -308,12 +308,12 @@ struct xfs_ag_geometry {
>> typedef struct xfs_growfs_data {
>> __u64 newblocks; /* new data subvol size, fsblocks */
>> __u32 imaxpct; /* new inode space percentage limit */
>> -} xfs_growfs_data_t;
>> +};
>
> So long as Eric is ok with fixing this up in xfs_fs_compat.h in
> userspace,
>
> Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
Sure, why not :) (tho is growfs really a public interface? I guess so,
technically, though not documented as such.)
Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>
-Eric
