On Wed, Dec 09, 2020 at 10:10:56AM -0800, Darrick J. Wong wrote: > On Wed, Dec 09, 2020 at 06:04:00PM +0000, Christoph Hellwig wrote: > > Who is going to set this flag? If the kernel ever sets it that is > > a good way to totally brick systems if it happens on the root file > > system. > > So far the only user is xfs_db, when xfs_admin tells it to upgrade a v5 > filesystem and we want/need to force the fs through xfs_repair: > > https://lore.kernel.org/linux-xfs/160679383892.447856.12907477074923729733.stgit@magnolia/T/#mad4ee9c757051692f33a993a348f4e4e61ac098b > https://lore.kernel.org/linux-xfs/160679383892.447856.12907477074923729733.stgit@magnolia/T/#mb6ef416f9626d87610625e069f516945783a5c13 > > I don't think there's ever going to be a use case for the kernel setting > the feature flag on a mounted fs -- if some error is fixable we should > just have online repair fix it; or if it's truly catastrophic we don't > want to write the disk at all. Maybe the definition wants a comment to explain this?
