On Wed, Oct 07, 2020 at 08:58:34PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > gcc 10.2 complains about the strncpy call here, since it's possible that > the source string is so long that the fspath inside the fdhash structure > will end up without a null terminator. Work around strncpy braindamage > yet again by forcing the string to be terminated properly. > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > --- > Unless this is supposed to be a memcpy? But it doesn't look like it. No, it should not be memcy, and the change looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx> That being said path_to_fspath where fspath originates is horrible and not mutlithreading safe due to the static filename buffer.
