From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> gcc 10.2 complains about the strncpy call here, since it's possible that the source string is so long that the fspath inside the fdhash structure will end up without a null terminator. Work around strncpy braindamage yet again by forcing the string to be terminated properly. Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> --- Unless this is supposed to be a memcpy? But it doesn't look like it. --- libhandle/handle.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libhandle/handle.c b/libhandle/handle.c index eb099f43791e..5c1686b3968d 100644 --- a/libhandle/handle.c +++ b/libhandle/handle.c @@ -107,7 +107,8 @@ path_to_fshandle( } fdhp->fsfd = fd; - strncpy(fdhp->fspath, fspath, sizeof(fdhp->fspath)); + strncpy(fdhp->fspath, fspath, sizeof(fdhp->fspath) - 1); + fdhp->fspath[sizeof(fdhp->fspath) - 1] = 0; memcpy(fdhp->fsh, *fshanp, FSIDSIZE); fdhp->fnxt = fdhash_head;
