that handled the !IKEEP behavior. >>> >>>> + return 0; >>>> + case Opt_noikeep: >>>> + xfs_warn(mp, "%s mount option is deprecated.", param->key); >>>> + mp->m_flags &= ~XFS_MOUNT_IKEEP; >>>> + return 0; >>>> + case Opt_attr2: >>>> + xfs_warn(mp, "%s mount option is deprecated.", param->key); >>>> + mp->m_flags |= XFS_MOUNT_ATTR2; > > Side note: shouldn't this clause be clearing XFS_MOUNT_NOATTR2? > I don't know but since nobody complained so far and we are actually starting work to remove it...I think it's safe to ignore that...?