On Tue, Sep 08, 2020 at 03:40:40PM +0100, Christoph Hellwig wrote: > On Mon, Sep 07, 2020 at 10:51:55AM -0700, Darrick J. Wong wrote: > > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > > > The minimum log size depends on the transaction reservation sizes, which > > in turn depend on the realtime device geometry. Therefore, we need to > > set up some of the rt geometry before we can compute the real minimum > > log size. > > > > This fixes a problem where mkfs, given a small data device and a > > realtime volume, formats a filesystem with a log that is too small to > > pass the mount time log size checks. > > Do we have a test for that? Yeah, I'm going to do a huge fstests patchbomb after I come back from vacation next week. Sorry I didn't quite get to it in time. --D > Othewise looks good: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx>