Re: [PATCH 4/4] mkfs: set required parts of the realtime geometry before computing log geometry

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 07, 2020 at 10:51:55AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> 
> The minimum log size depends on the transaction reservation sizes, which
> in turn depend on the realtime device geometry.  Therefore, we need to
> set up some of the rt geometry before we can compute the real minimum
> log size.
> 
> This fixes a problem where mkfs, given a small data device and a
> realtime volume, formats a filesystem with a log that is too small to
> pass the mount time log size checks.

Do we have a test for that?

Othewise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux