Re: [PATCH] xfs_io: Remove redundant setting/check for lsattr/stat command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH] xfs_io: Remove redundant setting/check for lsattr/stat command
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Wed, 29 Jul 2020 17:46:50 -0700
Cc: darrick.wong@xxxxxxxxxx
In-reply-to: <20200724071440.23239-1-yangx.jy@cn.fujitsu.com>
References: <20200724071440.23239-1-yangx.jy@cn.fujitsu.com>
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

On 7/24/20 12:14 AM, Xiao Yang wrote:
> lsattr/stat command can check exclusive options by argmax = 1
> so the related setting/check is redundant.
> 
> Signed-off-by: Xiao Yang <yangx.jy@xxxxxxxxxxxxxx>

Looks good.  I guess we are not very consistent about our use
of argmax :)

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>

References:
- [PATCH] xfs_io: Remove redundant setting/check for lsattr/stat command
  - From: Xiao Yang

Prev by Date: Re: [PATCH v2] xfs_io: Make -D and -R options incompatible explicitly
Next by Date: [RFC PATCH] iomap: add support to track dirty state of sub pages
Previous by thread: [PATCH] xfs_io: Remove redundant setting/check for lsattr/stat command
Next by thread: [PATCH v5 0/7] add support for direct I/O with fscrypt using blk-crypto
Index(es):
- Date
- Thread

[Index of Archives] [XFS Filesystem Development (older mail)] [Linux Filesystem Development] [Linux Audio Users] [Yosemite Trails] [Linux Kernel] [Linux RAID] [Linux SCSI]

Powered by Linux