On 7/23/20 11:32 PM, Xiao Yang wrote: > -D and -R options are mutually exclusive actually but many commands > can accept them at the same time and process them differently(e.g. > chattr alway chooses -D option or cowextsize accepts the last one > specified), so make these commands have the consistent behavior that > don't accept them concurrently. > > 1) Make them incompatible by setting argmax to 1 if commands can accept > single option(i.e. lsattr, lsproj). I see that lsattr already has argmax=1, so I guess that was ok. Still good to remove the extra vars from the cases. > 2) Make them incompatible by adding check if commands can accept multiple > options(i.e. chattr, chproj, extsize, cowextsize). > > Signed-off-by: Xiao Yang <yangx.jy@xxxxxxxxxxxxxx> Thank you for cleaning all of these up. Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>
