On Thu, Jul 16, 2020 at 06:05:28PM -0700, Darrick J. Wong wrote: > On Fri, Jul 17, 2020 at 10:13:59AM +1000, Dave Chinner wrote: > > On Wed, Jul 15, 2020 at 11:46:23PM -0700, Darrick J. Wong wrote: > > > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > > > > > Create an XFS_DQTYPE_ANY mask for ondisk dquots flags, and use that to > > > ensure that we never accept any garbage flags when we're loading dquots. > > > While we're at it, restructure the quota type flag checking to use the > > > proper masking. > > > > > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > > --- > > > fs/xfs/libxfs/xfs_dquot_buf.c | 11 ++++++++--- > > > fs/xfs/libxfs/xfs_format.h | 2 ++ > > > 2 files changed, 10 insertions(+), 3 deletions(-) > > > > Ok, I looked at this and questioned why it existed and why the > > code didn't just use XFS_DQTYPE_REC_MASK directly. I think this > > change exists because you plan on adding a new on-disk flag for > > bigtime support and hence XFS_DQTYPE_ANY will grow to include the > > new flag, right? > > Correct. > > > If so, can you add that to the commit message? > > Ok, will do. Thanks. With that: Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx
