On Wed, Jul 15, 2020 at 11:46:23PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > Create an XFS_DQTYPE_ANY mask for ondisk dquots flags, and use that to > ensure that we never accept any garbage flags when we're loading dquots. > While we're at it, restructure the quota type flag checking to use the > proper masking. > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > --- > fs/xfs/libxfs/xfs_dquot_buf.c | 11 ++++++++--- > fs/xfs/libxfs/xfs_format.h | 2 ++ > 2 files changed, 10 insertions(+), 3 deletions(-) Ok, I looked at this and questioned why it existed and why the code didn't just use XFS_DQTYPE_REC_MASK directly. I think this change exists because you plan on adding a new on-disk flag for bigtime support and hence XFS_DQTYPE_ANY will grow to include the new flag, right? If so, can you add that to the commit message? Code looks fine assuming I've understood this correctly... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx
