Re: [PATCH 09/11] xfs: create xfs_dqtype_t to represent quota types

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 15, 2020 at 11:46:16PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> 
> Create a new type (xfs_dqtype_t) to represent the type of an incore
> dquot (user, group, project, or none).  Rename the incore dquot's
> dq_flags field to q_type.
> 
> This allows us to replace all the "uint type" arguments to the quota
> functions with "xfs_dqtype_t type", to make it obvious when we're
> passing a quota type argument into a function.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> ---
>  fs/xfs/libxfs/xfs_dquot_buf.c  |    2 +-
>  fs/xfs/libxfs/xfs_format.h     |    9 +++++++++
>  fs/xfs/libxfs/xfs_quota_defs.h |   27 ++++++++++++---------------
>  fs/xfs/scrub/quota.c           |    8 ++++----
>  fs/xfs/scrub/repair.c          |    4 ++--
>  fs/xfs/scrub/repair.h          |    4 +++-
>  fs/xfs/xfs_dquot.c             |   37 +++++++++++++++++++------------------
>  fs/xfs/xfs_dquot.h             |   33 +++++++++++++++++----------------
>  fs/xfs/xfs_iomap.c             |   24 ++++++++++++------------
>  fs/xfs/xfs_qm.c                |   22 +++++++++++-----------
>  fs/xfs/xfs_qm.h                |   26 ++++++++++++++++----------
>  fs/xfs/xfs_qm_syscalls.c       |    8 ++++----
>  fs/xfs/xfs_quota.h             |    4 ++--
>  fs/xfs/xfs_quotaops.c          |    2 +-
>  fs/xfs/xfs_trace.h             |   21 +++++++++++++++------
>  15 files changed, 128 insertions(+), 103 deletions(-)

Looks fine.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
-- 
Dave Chinner
david@xxxxxxxxxxxxx



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux