On Wed, Jul 01, 2020 at 04:59:04PM +0800, Gao Xiang wrote:
> On Tue, Jun 23, 2020 at 07:50:14PM +1000, Dave Chinner wrote:
>
> ...
>
> > +static struct xfs_inode *
> > +xfs_iunlink_ilookup(
> > struct xfs_perag *pag,
> > xfs_agino_t agino)
> > {
> > - struct xfs_iunlink *iu;
> > + struct xfs_mount *mp = pag->pag_mount;
> > + struct xfs_inode *ip;
> >
> > - iu = rhashtable_lookup_fast(&pag->pagi_unlinked_hash, &agino,
> > - xfs_iunlink_hash_params);
>
> Just notice that when working on this patchset. Since pagi_unlinked_hash
> is unused now, let's kill pagi_unlinked_hash in xfs_perag as well.
>
> typedef struct xfs_perag {
> ...
> struct rhashtable pagi_unlinked_hash;
> ...
> };
Good catch. I'll remove that for the next iteration.
> Also I noticed xfs_iunlink_insert_inode and xfs_iunlink_remove_inode
> are used once now, maybe folding into the caller would be better...
> (Just my personal thought...)
I used them to make it obvious what operation was being performed on
the unlinked list. In the end they might be simple enough to remove,
but when I first wrote this patch is was necessary to document what
operations were being performed by the code rather than it just
being a big tangle of spagetti...
Cheers,
Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx
