On Tue, Jun 23, 2020 at 07:50:14PM +1000, Dave Chinner wrote:
...
> +static struct xfs_inode *
> +xfs_iunlink_ilookup(
> struct xfs_perag *pag,
> xfs_agino_t agino)
> {
> - struct xfs_iunlink *iu;
> + struct xfs_mount *mp = pag->pag_mount;
> + struct xfs_inode *ip;
>
> - iu = rhashtable_lookup_fast(&pag->pagi_unlinked_hash, &agino,
> - xfs_iunlink_hash_params);
Just notice that when working on this patchset. Since pagi_unlinked_hash
is unused now, let's kill pagi_unlinked_hash in xfs_perag as well.
typedef struct xfs_perag {
...
struct rhashtable pagi_unlinked_hash;
...
};
(I will try to add a mutex and a tail xfs_inode for this later
in this structure...)
Also I noticed xfs_iunlink_insert_inode and xfs_iunlink_remove_inode
are used once now, maybe folding into the caller would be better...
(Just my personal thought...)
Thanks,
Gao Xiang
