On Fri, Jun 05, 2020 at 12:26:37PM -0400, Brian Foster wrote: > On Thu, Jun 04, 2020 at 05:45:58PM +1000, Dave Chinner wrote: > > From: Dave Chinner <dchinner@xxxxxxxxxx> > > > > Clean up xfs_reclaim_inodes() callers. Most callers want blocking > > behaviour, so just make the existing SYNC_WAIT behaviour the > > default. > > > > For the xfs_reclaim_worker(), just call xfs_reclaim_inodes_ag() > > directly because we just want optimistic clean inode reclaim to be > > done in the background. > > > > For xfs_quiesce_attr() we can just remove the inode reclaim calls as > > they are a historic relic that was required to flush dirty inodes > > that contained unlogged changes. We now log all changes to the > > inodes, so the sync AIL push from xfs_log_quiesce() called by > > xfs_quiesce_attr() will do all the required inode writeback for > > freeze. > > > > The above change should probably be a standalone patch, but not worth > changing at this point: > > Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx> > > BTW, is there any reason we continue to drain the buffer lru for freeze > as well? Probably not - out of scope for this patch so I haven't really thought about it. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx
