On Fri, May 22, 2020 at 6:52 AM Dave Chinner <david@xxxxxxxxxxxxx> wrote: > > From: Dave Chinner <dchinner@xxxxxxxxxx> > > with xfs_iflush() gone, we can rename xfs_iflush_int() back to > xfs_iflush(). Also move it up above xfs_iflush_cluster() so we don't > need the forward definition any more. > If it were up to me, I would avoid the code churn involved with moving code around for the sole purpose of getting rid of forward definition. BTW, next patch removed the static from xfs_iflush(), but it looks like a mistake or part of your follow up series. If you are going to make xfs_iflush() non static it is really pointless to move it around. But for correctness: Reviewed-by: Amir Goldstein <amir73il@xxxxxxxxx> Thanks, Amir.
