On Thu, May 21, 2020 at 07:53:40PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
>
> Use XFS_ICI_NO_TAG instead of -1 when appropriate.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> ---
Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx>
> fs/xfs/xfs_icache.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>
> diff --git a/fs/xfs/xfs_icache.c b/fs/xfs/xfs_icache.c
> index 0ed904c2aa12..b1e2541810be 100644
> --- a/fs/xfs/xfs_icache.c
> +++ b/fs/xfs/xfs_icache.c
> @@ -815,7 +815,7 @@ xfs_inode_ag_walk(
>
> rcu_read_lock();
>
> - if (tag == -1)
> + if (tag == XFS_ICI_NO_TAG)
> nr_found = radix_tree_gang_lookup(&pag->pag_ici_root,
> (void **)batch, first_index,
> XFS_LOOKUP_BATCH);
> @@ -973,8 +973,8 @@ xfs_inode_ag_iterator_flags(
> ag = 0;
> while ((pag = xfs_perag_get(mp, ag))) {
> ag = pag->pag_agno + 1;
> - error = xfs_inode_ag_walk(mp, pag, execute, flags, args, -1,
> - iter_flags);
> + error = xfs_inode_ag_walk(mp, pag, execute, flags, args,
> + XFS_ICI_NO_TAG, iter_flags);
> xfs_perag_put(pag);
> if (error) {
> last_error = error;
>
