On Wed, May 20, 2020 at 07:48:39AM +1000, Dave Chinner wrote: > + /* > + * Debug checks outside of the spinlock so they don't lock up the > + * machine if they fail. > + */ > + ASSERT(&mp->m_sb.sb_frextents >= 0); > + ASSERT(&mp->m_sb.sb_dblocks >= 0); > + ASSERT(&mp->m_sb.sb_agcount >= 0); To stick to the theme of broken error handling I don't think this does what you think as this takes the address of each field, which will aways be >= 0. I like the idea of the patch, though.
