On Tue, May 19, 2020 at 06:46:27PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > Hide the incore inode walk interface because callers outside of the > icache code don't need to know about iter_flags and radix tags and other > implementation details of the incore inode cache. I don't really see the point here. It isn't hiding much, and only from a single caller. I have to say I also prefer the old naming over _ici_ and find the _all postfix not exactly descriptive.