On Sat, May 16, 2020 at 10:52:00AM -0700, Darrick J. Wong wrote: > On Fri, May 08, 2020 at 08:34:22AM +0200, Christoph Hellwig wrote: > > We don't call xfs_bmapi_read for the COW fork anymore, so remove the > > special casing. > > > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx> > > I was surprised this assertion, but apparently it's true, even in my dev > tree, so: We really shouldn't add more xfs_bmapi_read callers anyway. Going straight to the xfs_iext_* APIs pretty much always improves the code.