On Wed, May 13, 2020 at 09:19:50AM -0400, Brian Foster wrote: > > We scan all the rmaps for files that have nonzero size but zero extents, > > because the (forthcoming) inode fork repair will reset damaged forks > > back to extents format with zero extents, and this is how we will > > trigger the bmap repair to get the extents mapped back into the file. > > > > Not sure I follow. Does this mean we're basically looking at sparse > files as "suspect" because we'd expect them to have extents? Why are we > looking at i_size here instead of fork size like for the attr fork, for > example? Either way it sounds like we're getting into some twisty repair > logic so perhaps this is beyond the scope of Christoph's patches.. The patch can be easily dropped from the series. I just noticed something fishy while looking over the code and though the fix would be easy enough..
