On 5/12/20 3:09 AM, Christoph Hellwig wrote:
>> +static uint32_t
>> +id_from_string(
>> + char *name,
>> + int type)
>> +{
>> + uint32_t id = -1;
>> + const char *type_name = "unknown type";
>
> Any reason to align the arguments different from the local variables?
nah I'll fix that on the way in
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
>
thanks!
