> +static uint32_t > +id_from_string( > + char *name, > + int type) > +{ > + uint32_t id = -1; > + const char *type_name = "unknown type"; Any reason to align the arguments different from the local variables? Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>