On Wed, Apr 29, 2020 at 01:21:43PM -0400, Brian Foster wrote: > At unmount time, XFS emits an alert for every in-core buffer that > might have undergone a write error. In practice this behavior is > probably reasonable given that the filesystem is likely short lived > once I/O errors begin to occur consistently. Under certain test or > otherwise expected error conditions, this can spam the logs and slow > down the unmount. > > Now that we have a ratelimit mechanism specifically for buffer > alerts, reuse it for the per-buffer alerts in xfs_wait_buftarg(). > Also lift the final repair message out of the loop so it always > prints and assert that the metadata error handling code has shut > down the fs. > > Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx> As Dave pointed out the ASSERT seems to agressive (and not really related to the rate limiting). Except for the ASSERT this looks fine: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
