On Wed, Apr 29, 2020 at 01:21:42PM -0400, Brian Foster wrote: > XFS has some inconsistent log message rate limiting with respect to > buffer alerts. The metadata I/O error notification uses the generic > ratelimited alert, the buffer push code uses a custom rate limit and > the similar quiesce time failure checks are not rate limited at all > (when they should be). > > The custom rate limit defined in the buf item code is specifically > crafted for buffer alerts. It is more aggressive than generic rate > limiting code because it must accommodate a high frequency of I/O > error events in a relative short timeframe. > > Factor out the custom rate limit state from the buf item code into a > per-buftarg rate limit so various alerts are limited based on the > target. Define a buffer alert helper function and use it for the > buffer alerts that are already ratelimited. > > Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx> Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx>
