On Mon, Apr 27, 2020 at 08:56:18AM -0700, Darrick J. Wong wrote: > On Sat, Apr 25, 2020 at 07:05:09PM +0530, Nishad Kamdar wrote: > > This patch corrects the SPDX License Identifier style in > > header files related to XFS File System support. > > For C header files Documentation/process/license-rules.rst > > mandates C-like comments (opposed to C source files where > > C++ style should be used). > > > > Changes made by using a script provided by Joe Perches here: > > https://lkml.org/lkml/2019/2/7/46. > > > > Suggested-by: Joe Perches <joe@xxxxxxxxxxx> > > Signed-off-by: Nishad Kamdar <nishadkamdar@xxxxxxxxx> > > --- > > fs/xfs/kmem.h | 2 +- > > fs/xfs/libxfs/xfs_ag_resv.h | 2 +- > > fs/xfs/libxfs/xfs_alloc.h | 2 +- > > fs/xfs/libxfs/xfs_alloc_btree.h | 2 +- > > fs/xfs/libxfs/xfs_attr.h | 2 +- > > fs/xfs/libxfs/xfs_attr_leaf.h | 2 +- > > fs/xfs/libxfs/xfs_attr_remote.h | 2 +- > > fs/xfs/libxfs/xfs_attr_sf.h | 2 +- > > fs/xfs/libxfs/xfs_bit.h | 2 +- > > fs/xfs/libxfs/xfs_bmap.h | 2 +- > > fs/xfs/libxfs/xfs_bmap_btree.h | 2 +- > > fs/xfs/libxfs/xfs_btree.h | 2 +- > > fs/xfs/libxfs/xfs_da_btree.h | 2 +- > > fs/xfs/libxfs/xfs_da_format.h | 2 +- > > fs/xfs/libxfs/xfs_defer.h | 2 +- > > fs/xfs/libxfs/xfs_dir2.h | 2 +- > > fs/xfs/libxfs/xfs_dir2_priv.h | 2 +- > > fs/xfs/libxfs/xfs_errortag.h | 2 +- > > fs/xfs/libxfs/xfs_format.h | 2 +- > > fs/xfs/libxfs/xfs_fs.h | 2 +- > > fs/xfs/libxfs/xfs_health.h | 2 +- > > fs/xfs/libxfs/xfs_ialloc.h | 2 +- > > fs/xfs/libxfs/xfs_ialloc_btree.h | 2 +- > > fs/xfs/libxfs/xfs_inode_buf.h | 2 +- > > fs/xfs/libxfs/xfs_inode_fork.h | 2 +- > > fs/xfs/libxfs/xfs_log_format.h | 2 +- > > fs/xfs/libxfs/xfs_log_recover.h | 2 +- > > fs/xfs/libxfs/xfs_quota_defs.h | 2 +- > > fs/xfs/libxfs/xfs_refcount.h | 2 +- > > fs/xfs/libxfs/xfs_refcount_btree.h | 2 +- > > fs/xfs/libxfs/xfs_rmap.h | 2 +- > > fs/xfs/libxfs/xfs_rmap_btree.h | 2 +- > > fs/xfs/libxfs/xfs_sb.h | 2 +- > > fs/xfs/libxfs/xfs_shared.h | 2 +- > > fs/xfs/libxfs/xfs_trans_resv.h | 2 +- > > fs/xfs/libxfs/xfs_trans_space.h | 2 +- > > fs/xfs/libxfs/xfs_types.h | 2 +- > > fs/xfs/mrlock.h | 2 +- > > fs/xfs/scrub/bitmap.h | 2 +- > > fs/xfs/scrub/btree.h | 2 +- > > fs/xfs/scrub/common.h | 2 +- > > fs/xfs/scrub/dabtree.h | 2 +- > > fs/xfs/scrub/health.h | 2 +- > > fs/xfs/scrub/repair.h | 2 +- > > fs/xfs/scrub/scrub.h | 2 +- > > fs/xfs/scrub/trace.h | 2 +- > > fs/xfs/scrub/xfs_scrub.h | 2 +- > > fs/xfs/xfs.h | 2 +- > > fs/xfs/xfs_acl.h | 2 +- > > fs/xfs/xfs_aops.h | 2 +- > > fs/xfs/xfs_bmap_item.h | 2 +- > > fs/xfs/xfs_bmap_util.h | 2 +- > > fs/xfs/xfs_buf.h | 2 +- > > fs/xfs/xfs_buf_item.h | 2 +- > > fs/xfs/xfs_dquot.h | 2 +- > > fs/xfs/xfs_dquot_item.h | 2 +- > > fs/xfs/xfs_error.h | 2 +- > > fs/xfs/xfs_export.h | 2 +- > > fs/xfs/xfs_extent_busy.h | 2 +- > > fs/xfs/xfs_extfree_item.h | 2 +- > > fs/xfs/xfs_filestream.h | 2 +- > > fs/xfs/xfs_fsmap.h | 2 +- > > fs/xfs/xfs_fsops.h | 2 +- > > fs/xfs/xfs_icache.h | 2 +- > > fs/xfs/xfs_icreate_item.h | 2 +- > > fs/xfs/xfs_inode.h | 2 +- > > fs/xfs/xfs_inode_item.h | 2 +- > > fs/xfs/xfs_ioctl.h | 2 +- > > fs/xfs/xfs_ioctl32.h | 2 +- > > fs/xfs/xfs_iomap.h | 2 +- > > fs/xfs/xfs_iops.h | 2 +- > > fs/xfs/xfs_itable.h | 2 +- > > fs/xfs/xfs_linux.h | 2 +- > > fs/xfs/xfs_log.h | 2 +- > > fs/xfs/xfs_log_priv.h | 2 +- > > fs/xfs/xfs_mount.h | 2 +- > > fs/xfs/xfs_mru_cache.h | 2 +- > > fs/xfs/xfs_ondisk.h | 2 +- > > fs/xfs/xfs_qm.h | 2 +- > > fs/xfs/xfs_quota.h | 2 +- > > fs/xfs/xfs_refcount_item.h | 2 +- > > fs/xfs/xfs_reflink.h | 2 +- > > fs/xfs/xfs_rmap_item.h | 2 +- > > fs/xfs/xfs_rtalloc.h | 2 +- > > fs/xfs/xfs_stats.h | 2 +- > > fs/xfs/xfs_super.h | 2 +- > > fs/xfs/xfs_symlink.h | 2 +- > > fs/xfs/xfs_sysctl.h | 2 +- > > fs/xfs/xfs_sysfs.h | 2 +- > > fs/xfs/xfs_trace.h | 2 +- > > fs/xfs/xfs_trans.h | 2 +- > > fs/xfs/xfs_trans_priv.h | 2 +- > > 92 files changed, 92 insertions(+), 92 deletions(-) > > > > diff --git a/fs/xfs/kmem.h b/fs/xfs/kmem.h > > index 6143117770e9..fc87ea9f6843 100644 > > --- a/fs/xfs/kmem.h > > +++ b/fs/xfs/kmem.h > > @@ -1,4 +1,4 @@ > > -// SPDX-License-Identifier: GPL-2.0 > > +/* SPDX-License-Identifier: GPL-2.0 */ > > /* > > * Copyright (c) 2000-2005 Silicon Graphics, Inc. > > * All Rights Reserved. > > diff --git a/fs/xfs/libxfs/xfs_ag_resv.h b/fs/xfs/libxfs/xfs_ag_resv.h > > index c0352edc8e41..f3fd0ee9a7f7 100644 > > --- a/fs/xfs/libxfs/xfs_ag_resv.h > > +++ b/fs/xfs/libxfs/xfs_ag_resv.h > > @@ -1,4 +1,4 @@ > > -// SPDX-License-Identifier: GPL-2.0+ > > +/* SPDX-License-Identifier: GPL-2.0+ */ > > I thought we were supposed to use 'GPL-2.0-or-newer' because 'GPL-2.0+' > is deprecated in some newer version of the SPDX standard? > > <shrug> The kernel follows the "older" SPDX standard, but will accept either, it's up to the author. It is all documented in LICENSES/ if people really want to make sure. thanks, greg k-h