On 4/20/20 7:05 PM, Darrick J. Wong wrote: > On Mon, Apr 20, 2020 at 03:33:36PM -0500, Eric Sandeen wrote: >> On 4/20/20 2:52 PM, Anthony Iliopoulos wrote: >>> The nowrite_ops var is declared within nested block scope but used >>> outside that scope, causing xfs_db to crash while trying to defererence >>> the verify_write pointer. Fix it by lifting the declaration to the outer >>> scope, where it is accessed. >>> >>> Signed-off-by: Anthony Iliopoulos <ailiop@xxxxxxxx> >> >> Yup, thanks for spotting & fixing this. >> >> Fixes: b64af2c "xfs_db: add crc manipulation commands" > > <nitpick> commit ids should be 14(?) digits long these days. hm yeah I should fix that. (tho in xfsprogs probably less necessary) >> Reviewd-by: Eric Sandeen <sandeen@xxxxxxxxxx> > > "Pat, I'd like to buy a vowel..." :D sigh, you'd think I'd have hotkeys by now?
