On 4/20/20 2:52 PM, Anthony Iliopoulos wrote:
> The nowrite_ops var is declared within nested block scope but used
> outside that scope, causing xfs_db to crash while trying to defererence
> the verify_write pointer. Fix it by lifting the declaration to the outer
> scope, where it is accessed.
>
> Signed-off-by: Anthony Iliopoulos <ailiop@xxxxxxxx>
Yup, thanks for spotting & fixing this.
Fixes: b64af2c "xfs_db: add crc manipulation commands"
Reviewd-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---
> db/crc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/db/crc.c b/db/crc.c
> index 95161c6df..b23417a11 100644
> --- a/db/crc.c
> +++ b/db/crc.c
> @@ -53,6 +53,7 @@ crc_f(
> char **argv)
> {
> const struct xfs_buf_ops *stashed_ops = NULL;
> + struct xfs_buf_ops nowrite_ops;
> extern char *progname;
> const field_t *fields;
> const ftattr_t *fa;
> @@ -127,7 +128,6 @@ crc_f(
> }
>
> if (invalidate) {
> - struct xfs_buf_ops nowrite_ops;
> flist_t *sfl;
> int bit_length;
> int parentoffset;
>
