On Mon, Mar 23, 2020 at 09:51:54AM -0700, Christoph Hellwig wrote: > On Mon, Mar 23, 2020 at 08:10:54AM -0700, Matthew Wilcox wrote: > > > That looks silly to me. This just means we'll keep iterating over > > > small bios for readahead.. Either we just ignore the different gfp > > > mask, or we need to go all the way and handle errors, although that > > > doesn't really look nice. > > > > I'm not sure it's silly, > > Oh well, I'm not going to be in the way of fixing a bug I added. So > feel free to go ahead with this and mention it matches mpage_readpages. Are you going to submit this as a formal patch?