On Mon, Mar 23, 2020 at 06:12:44AM -0700, Matthew Wilcox wrote:
> From: "Matthew Wilcox (Oracle)" <willy@xxxxxxxxxxxxx>
>
> If we use GFP_NORETRY, we have to be able to handle failures, and it's
> tricky to handle failure here. Other implementations of ->readpages
> do not attempt to handle BIO allocation failures, so this is no worse.
do_mpage_readpage tries to use it, I guess that is wher I copied it
from..
But I don't think it is a bad idea, so the patch itself looks good:
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
It probably wants a fixes tag, though:
Fixes: 72b4daa24129 ("iomap: add an iomap-based readpage and readpages implementation")
